feat(parity): replicate batch items pickup, dragon soul refine packet, target sync, and attackability (pass35)

This commit is contained in:
shen
2026-10-08 02:11:08 -07:00
parent 9a635932d6
commit efd3a44fa0
6 changed files with 181 additions and 5 deletions
+1 -1
View File
@@ -1,6 +1,6 @@
{
"reference": "upstream/ava2-client/UserInterface/Packet.h preprocessed with AVA2 Windows feature headers",
"checked": 243,
"checked": 301,
"mismatches": [],
"unmatched": []
}
+22
View File
@@ -785,3 +785,25 @@ Validation: macOS build and Android arm64 libmain.so pass. Five targeted CTests
- CTest suite: **41/41 tests passed (100%)**.
- Android arm64 `libmain.so` and macOS arm64 `ava2_client` build cleanly.
## 2026-10-08 pass35 — Batch items pickup, dragon soul refine packet, target sync, and attackability parity
- **Comprehensive Packet Constants Expansion (`src/eter_net/Packet.h`)**:
- Added 58 missing packet constants to `EPacketCG` and `EPacketGC` including `HEADER_CG_ITEMS_PICKUP = 235`, `HEADER_CG_DRAGON_SOUL_REFINE = 205`, `HEADER_CG_PVP = 41`, `HEADER_CG_SHOP = 50`, `HEADER_CG_MYSHOP = 55`, `HEADER_CG_OFFLINE_SHOP = 57`, `HEADER_CG_EMPIRE = 90`, `HEADER_GC_EMPIRE = 90`, `HEADER_CG_DUNGEON = 110`, `HEADER_CG_SASH = 211`, `HEADER_CG_FISHING = 222`, etc.
- Checked packet constants increased from 243 to **301/301 (100% parity)** with 0 mismatches and 0 unmatched.
- Added wire structures `TPacketCGItemsPickUp` and `TPacketCGDragonSoulRefine`.
- **Batch Ground Item Pickup Parity (`PythonNetworkStream.h` / `.cpp`, `python_gameplay_modules.cpp`)**:
- Implemented `SendItemsPickUpPacket(const std::vector<uint32_t>& itemVector)` sending `TPacketCGItemsPickUp` followed by vector item VIDs.
- Updated `player_PickCloseItemVector` to send a single batch `SendItemsPickUpPacket` rather than looping individual single item packets, matching upstream `CPythonPlayer::SendPickUPItemPacket`.
- **Dragon Soul Refinement Parity (`PythonNetworkStream.h` / `.cpp`, `python_gameplay_modules.cpp`)**:
- Implemented `SendDragonSoulRefinePacket(uint8_t bRefineType, const TItemPos* pos)` matching upstream `CPythonNetworkStream::SendDragonSoulRefinePacket`.
- Replicated `player_SendDragonSoulRefine` 1:1, parsing dictionary `(window_type, cell)` into `TItemPos RefineItemPoses[DS_REFINE_WINDOW_MAX_NUM]` and dispatching the network packet.
- **Targeting & Attackability Parity (`python_gameplay_modules.cpp`)**:
- Updated `player_SetTarget` and `player_ClearTarget` (and `player_Clear`) to send `SendTargetPacket(vid)` / `SendTargetPacket(0)`.
- Replicated upstream `CInstanceBase::IsAttackableInstance` in `player_CanAttackInstance`: friendly NPCs (`bType == 1`) return false, monsters (`bType == 0`) return true, and PCs check killer state, empire, PK mode (Free, Revenge alignment conflict, Guild), and self VID.
- **Results**:
- Checked packet constants: **301/301 (100%)**, 0 mismatches, 0 unmatched.
- `python3 tools/audit_windows_parity.py`: **0 placeholder bindings**.
- `python3 tools/audit_ava2_python_interfaces.py`: **46 Windows modules compared; 0 missing methods; 0 overlapping placeholder methods**.
- CTest suite: **41/41 tests passed (100%)**.
- Android arm64 `libmain.so` and macOS arm64 `ava2_client` build cleanly.