ReadViewSDK/Sources/RDReaderView/EPUBCore/CFI/RDEPUBCFIRange.swift
shenlei f50495ad91 fix: CFI module — 11 issues from code review
Phase 1 (correctness):
- #1: rawValue changed from stored to computed property, eliminating stale cache risk
- #2: tokenSamples/textMarker unified to UTF-16 offsets, fixing emoji/CJK positioning
- #3: makeOffsetCFI now accepts optional contentPath parameter

Phase 2 (robustness):
- #4: Resolver uses fixed index access instead of last(where:) for manifest/spine steps
- #5: HTML comments and CDATA stripped before regex matching
- #6: Text assertion parser handles backslash escapes (\[ \] \)
- #7: Token matching uses prefix/suffix with length ratio constraints
- #8: makeOffsetRangeCFI validates startOffset <= endOffset

Phase 3 (code quality):
- #9: Shared internal nilIfEmpty extension in RDEPUBCFIUtilities.swift
- #10: RDEPUBCFIMap has markerByPath index dictionary for O(1) lookup
- #11: parseRange unified to use try (not try?) for parent parsing

Review fixes:
- Documented init(rawValue:) parameter is ignored (computed property)
- Fixed escape unescaping to handle \\ → \ correctly
- Lowered token minLength threshold from 4 to 2

Co-Authored-By: Claude <noreply@anthropic.com>
2026-06-18 13:25:17 +08:00

34 lines
1.2 KiB
Swift

import Foundation
public struct RDEPUBCFIRange: Codable, Equatable, Hashable {
public var parent: RDEPUBCFI?
public var start: RDEPUBCFI
public var end: RDEPUBCFI
/// Always computed from components no stale cached value risk.
public var rawValue: String {
RDEPUBCFISerializer.serializeRange(self)
}
/// Initialize from components. The `rawValue` parameter is ignored rawValue is always
/// computed from the components. To parse a CFI range string, use `RDEPUBCFIParser.parseRange(_:)`.
public init(rawValue: String = "", parent: RDEPUBCFI? = nil, start: RDEPUBCFI, end: RDEPUBCFI) {
self.parent = parent
self.start = start
self.end = end
}
public init(from decoder: Decoder) throws {
let container = try decoder.singleValueContainer()
let rawValue = try container.decode(String.self)
let parsed = try RDEPUBCFIParser.parseRange(rawValue)
self.parent = parsed.parent
self.start = parsed.start
self.end = parsed.end
}
public func encode(to encoder: Encoder) throws {
var container = encoder.singleValueContainer()
try container.encode(rawValue)
}
}