4v5u09Z5a4Yuc/mtgodot-poc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

port: P3-e PythonMiniMap + miniMap module (1:1 40250)

Browse Source 
Copy PythonMiniMap.cpp/PythonMiniMapModule.cpp and PRTerrainLib/StdAfx.cpp
verbatim, drop the pending stand-in and the miniMap module stub, register
initMiniMap() after initnet(). PR_FLOAT_TO_INTASM uses lrintf off MSVC;
D3DXColorModulate added. CMapOutdoor is not ported, so the pending
CMapManager::IsMapOutdoor() returns false (DIVERGENT) and the minimap's terrain
and atlas paths stay on 40250's no-outdoor-map branch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
shenlei
2026-09-24 01:18:57 +09:00
co-authored by Claude Opus 5.5
parent 070a27b2cb
commit 7358bf444a
18 changed files with 2429 additions and 158 deletions
Download Patch File Download Diff File Expand all files Collapse all files
audit/history.jsonl
+1
View File
@@ -534,3 +534,4 @@
{"time": "2026-09-24T07:00:00Z", "event": "port_round", "unit": "PORT-PLAN batch 2 P3-b: PythonItem + PythonItemModule", "ported": ["UserInterface/PythonItem.cpp", "UserInterface/PythonItemModule.cpp"], "adapted": ["UserInterface/PythonItemModule.cpp:itemGetIconImage", "GameLib/MapManager.cpp:CMapManager::GetNormal"], "divergent": [], "needs_live": [], "tests": ["port.login_flow: fake GC_ITEM_GROUND_ADD vnum 19 + ownership, player.PickCloseItem -> CG_ITEM_PICKUP -> GC_ITEM_GROUND_DEL removes it", "port.login_flow: item.SelectItem(19) name/type/subtype/value", "port.login_live 192.168.21.203: passes (icon pointer truncation segfault fixed)", "ctest all 19/19, python_game_render_test offline PASS", "port_map.py check: 0 errors"], "todo": ["P3-c PythonExchange", "PythonTextTail item tails (Register/Delete/SetOwner/Pick still stubs)", "CEffectManager (dropitem.mse)"]}
{"time": "2026-09-24T08:00:00Z", "event": "port_round", "unit": "PORT-PLAN batch 2 P3-c: PythonExchange + PythonExchangeModule", "ported": ["UserInterface/PythonExchange.cpp", "UserInterface/PythonExchangeModule.cpp"], "adapted": [], "divergent": [], "needs_live": ["exchange with a real second player"], "tests": ["port.login_flow: net.SendExchangeStartPacket -> fake GC_EXCHANGE START/ITEM_ADD/GOLD_ADD fills target side, uiexchange opens; SendExchangeExitPacket -> END closes", "port.login_live 192.168.21.203: passes", "ctest all 19/19, python_game_render_test offline PASS", "port_map.py check: 0 errors"], "todo": ["PythonTextTail item tails", "PythonMiniMap", "CEffectManager", "CPythonSkill"]}
{"time": "2026-09-24T09:00:00Z", "event": "port_round", "unit": "PORT-PLAN batch 2 P3-d: PythonTextTail + textTail module", "ported": ["UserInterface/PythonTextTail.cpp", "UserInterface/PythonTextTailModule.cpp"], "adapted": ["EterLib/GrpScreen.cpp:CScreen::ProjectPosition", "EterLib/GrpScreen.cpp:CScreen::UnprojectPosition", "UserInterface/UserInterface.cpp:ApplicationStringTable_GetString", "UserInterface/UserInterface.cpp:ApplicationStringTable_GetStringz"], "divergent": [], "needs_live": [], "tests": ["port.login_flow: ground item name tail registered, ALT frame projects it, CPythonTextTail::Pick returns the item VID, deleted on pickup", "port.login_live 192.168.21.203: passes", "ctest all 19/19, python_game_render_test offline PASS", "port_map.py check: 0 errors"], "todo": ["PythonMiniMap", "CEffectManager", "CPythonSkill"]}
{"time": "2026-09-24T10:00:00Z", "event": "port_round", "unit": "PORT-PLAN batch 2 P3-e: PythonMiniMap + miniMap module", "ported": ["UserInterface/PythonMiniMap.cpp", "UserInterface/PythonMiniMapModule.cpp", "PRTerrainLib/StdAfx.cpp"], "adapted": [], "divergent": ["GameLib/MapManager.cpp:CMapManager::IsMapOutdoor (false until CMapOutdoor is ported)"], "needs_live": [], "tests": ["port.login_flow: miniMap.isShow() after uiminimap, GetAtlasSize() not loaded", "port.login_live 192.168.21.203: passes", "ctest all 19/19, python_game_render_test offline PASS", "port_map.py check: 0 errors"], "todo": ["CMapOutdoor (minimap terrain textures, atlas)", "CEffectManager", "CPythonSkill"]}
audit/port-map/GameLib/MapManager.cpp.json
+6 -1
View File
@@ -5,7 +5,12 @@
"contracts": [],
"functions": {
"CMapManager::IsMapOutdoor": {
"status": "TODO"
"status": "DIVERGENT",
"impl": [
"extension/src/platform/pending/GameLib/MapManager.cpp:CMapManager::IsMapOutdoor"
],
"note": "Returns false on every map: CMapOutdoor is not ported (the Godot terrain adapter draws the map), so CPythonMiniMap Update/Render/LoadAtlas take their no-outdoor-map path: no minimap terrain textures, marks or atlas. Resolves when CMapOutdoor is ported.",
"test": "extension/tests/port_login_flow_test.cpp miniMap step (miniMap.GetAtlasSize() reports not loaded)"
},
"CMapManager::GetMapOutdoorRef": {
"status": "TODO"
audit/port-map/UserInterface/PythonMiniMap.cpp.json
+320
View File
@@ -0,0 +1,320 @@
{
"reference": "UserInterface/PythonMiniMap.cpp",
"reference_sha256": "bc931ed36fd90f631ee8c287cdf3816d58e9ee640511afc36ac2a684d69de738",
"priority": "P3",
"contracts": [],
"functions": {
"CPythonMiniMap::AddObserver": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::AddObserver"
]
},
"CPythonMiniMap::MoveObserver": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::MoveObserver"
]
},
"CPythonMiniMap::RemoveObserver": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::RemoveObserver"
]
},
"CPythonMiniMap::SetCenterPosition": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::SetCenterPosition"
]
},
"CPythonMiniMap::Update": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::Update"
]
},
"CPythonMiniMap::Render": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::Render"
]
},
"CPythonMiniMap::SetScale": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::SetScale"
]
},
"CPythonMiniMap::ScaleUp": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::ScaleUp"
]
},
"CPythonMiniMap::ScaleDown": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::ScaleDown"
]
},
"CPythonMiniMap::SetMiniMapSize": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::SetMiniMapSize"
]
},
"CPythonMiniMap::Create": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::Create"
]
},
"CPythonMiniMap::__SetPosition": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::__SetPosition"
]
},
"CPythonMiniMap::ClearAtlasMarkInfo": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::ClearAtlasMarkInfo"
]
},
"CPythonMiniMap::RegisterAtlasMark": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::RegisterAtlasMark"
]
},
"CPythonMiniMap::ClearGuildArea": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::ClearGuildArea"
]
},
"CPythonMiniMap::RegisterGuildArea": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::RegisterGuildArea"
]
},
"CPythonMiniMap::GetGuildAreaID": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::GetGuildAreaID"
]
},
"CPythonMiniMap::CreateTarget": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::CreateTarget"
]
},
"CPythonMiniMap::UpdateTarget": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::UpdateTarget"
]
},
"CPythonMiniMap::DeleteTarget": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::DeleteTarget"
]
},
"CPythonMiniMap::__LoadAtlasMarkInfo": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::__LoadAtlasMarkInfo"
]
},
"CPythonMiniMap::LoadAtlas": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::LoadAtlas"
]
},
"CPythonMiniMap::__GlobalPositionToAtlasPosition": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::__GlobalPositionToAtlasPosition"
]
},
"CPythonMiniMap::UpdateAtlas": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::UpdateAtlas"
]
},
"CPythonMiniMap::RenderAtlas": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::RenderAtlas"
]
},
"CPythonMiniMap::GetPickedInstanceInfo": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::GetPickedInstanceInfo"
]
},
"CPythonMiniMap::GetAtlasInfo": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::GetAtlasInfo"
]
},
"CPythonMiniMap::GetAtlasSize": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::GetAtlasSize"
]
},
"CPythonMiniMap::AddWayPoint": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::AddWayPoint"
]
},
"CPythonMiniMap::RemoveWayPoint": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::RemoveWayPoint"
]
},
"CPythonMiniMap::__GetWayPoint": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::__GetWayPoint"
]
},
"CPythonMiniMap::__UpdateWayPoint": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::__UpdateWayPoint"
]
},
"CPythonMiniMap::__RenderWayPointMark": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::__RenderWayPointMark"
]
},
"CPythonMiniMap::__RenderMiniWayPointMark": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::__RenderMiniWayPointMark"
]
},
"CPythonMiniMap::__RenderTargetMark": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::__RenderTargetMark"
]
},
"CPythonMiniMap::AddSignalPoint": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::AddSignalPoint"
]
},
"CPythonMiniMap::ClearAllSignalPoint": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::ClearAllSignalPoint"
]
},
"CPythonMiniMap::RegisterAtlasWindow": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::RegisterAtlasWindow"
]
},
"CPythonMiniMap::UnregisterAtlasWindow": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::UnregisterAtlasWindow"
]
},
"CPythonMiniMap::OpenAtlasWindow": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::OpenAtlasWindow"
]
},
"CPythonMiniMap::SetAtlasCenterPosition": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::SetAtlasCenterPosition"
]
},
"CPythonMiniMap::IsAtlas": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::IsAtlas"
]
},
"CPythonMiniMap::ShowAtlas": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::ShowAtlas"
]
},
"CPythonMiniMap::HideAtlas": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::HideAtlas"
]
},
"CPythonMiniMap::CanShowAtlas": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::CanShowAtlas"
]
},
"CPythonMiniMap::CanShow": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::CanShow"
]
},
"CPythonMiniMap::Show": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::Show"
]
},
"CPythonMiniMap::Hide": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::Hide"
]
},
"CPythonMiniMap::__Initialize": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::__Initialize"
]
},
"CPythonMiniMap::Destroy": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::Destroy"
]
},
"CPythonMiniMap::CPythonMiniMap": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::CPythonMiniMap"
]
},
"CPythonMiniMap::~CPythonMiniMap": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMap.cpp:CPythonMiniMap::~CPythonMiniMap"
]
}
}
}
audit/port-map/UserInterface/PythonMiniMapModule.cpp.json
+176
View File
@@ -0,0 +1,176 @@
{
"reference": "UserInterface/PythonMiniMapModule.cpp",
"reference_sha256": "49293a3eacbb0118f611968a2f6f635cdba66a7db63630330768006d007a6c32",
"priority": "P4",
"contracts": [],
"functions": {
"miniMapSetScale": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMapModule.cpp:miniMapSetScale"
]
},
"miniMapSetCenterPosition": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMapModule.cpp:miniMapSetCenterPosition"
]
},
"miniMapSetMiniMapSize": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMapModule.cpp:miniMapSetMiniMapSize"
]
},
"miniMapDestroy": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMapModule.cpp:miniMapDestroy"
]
},
"miniMapCreate": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMapModule.cpp:miniMapCreate"
]
},
"miniMapUpdate": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMapModule.cpp:miniMapUpdate"
]
},
"miniMapRender": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMapModule.cpp:miniMapRender"
]
},
"miniMapShow": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMapModule.cpp:miniMapShow"
]
},
"miniMapHide": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMapModule.cpp:miniMapHide"
]
},
"miniMapisShow": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMapModule.cpp:miniMapisShow"
]
},
"miniMapScaleUp": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMapModule.cpp:miniMapScaleUp"
]
},
"miniMapScaleDown": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMapModule.cpp:miniMapScaleDown"
]
},
"miniMapGetInfo": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMapModule.cpp:miniMapGetInfo"
]
},
"miniMapLoadAtlas": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMapModule.cpp:miniMapLoadAtlas"
]
},
"miniMapUpdateAtlas": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMapModule.cpp:miniMapUpdateAtlas"
]
},
"miniMapRenderAtlas": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMapModule.cpp:miniMapRenderAtlas"
]
},
"miniMapShowAtlas": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMapModule.cpp:miniMapShowAtlas"
]
},
"miniMapHideAtlas": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMapModule.cpp:miniMapHideAtlas"
]
},
"miniMapisShowAtlas": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMapModule.cpp:miniMapisShowAtlas"
]
},
"miniMapIsAtlas": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMapModule.cpp:miniMapIsAtlas"
]
},
"miniMapGetAtlasInfo": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMapModule.cpp:miniMapGetAtlasInfo"
]
},
"miniMapGetAtlasSize": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMapModule.cpp:miniMapGetAtlasSize"
]
},
"miniMapAddWayPoint": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMapModule.cpp:miniMapAddWayPoint"
]
},
"miniMapRemoveWayPoint": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMapModule.cpp:miniMapRemoveWayPoint"
]
},
"miniMapRegisterAtlasWindow": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMapModule.cpp:miniMapRegisterAtlasWindow"
]
},
"miniMapUnregisterAtlasWindow": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMapModule.cpp:miniMapUnregisterAtlasWindow"
]
},
"miniMapGetGuildAreaID": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMapModule.cpp:miniMapGetGuildAreaID"
]
},
"initMiniMap": {
"status": "PORTED",
"impl": [
"extension/src/port/UserInterface/PythonMiniMapModule.cpp:initMiniMap"
]
}
}
}