Files
metin2-server/tests/features/test_switchbot.py
T
shenleiandClaude Opus 5.5 afb3dfb1db Add server-authoritative switchbot (automatic attribute change) v1
/mt_switchbot 1 attrs|start|stop|status runs one bot per character that
calls the original UseItem path every 250 ms, so checks, probabilities,
ItemLog CHANGE_ATTRIBUTE and scroll use are the manual path's. Up to two
alternatives of 1-5 targets; stops on matched/limit/no_scroll/item_gone/
rejected/busy/stopped, erased on logout or warp. Per-roll INFO lines are
held back via a quiet flag on ChatPacket. MTF1 cap mask advertises 64.

Verified live on 203 with an extra channel-5 core (port 13040) running the
isolated build: limit, matched, already-matched, move during run, stop and
logout during run; 72 ItemLog rows for 72 rolls. No attribute lock yet.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-15 19:45:10 +09:00

175 lines
11 KiB
Python

#!/usr/bin/env python3
"""Compile the production switchbot header against stubs of the original UseItem/ChatPacket contract."""
from pathlib import Path
import subprocess
import tempfile
ROOT=Path(__file__).resolve().parents[2]
SRC=ROOT/'src/server/game/src'
# The quiet-INFO branch must stay in the real ChatPacket; the stub below mirrors it.
assert 'if (m_portQuietInfo && type == CHAT_TYPE_INFO)' in (SRC/'char.cpp').read_bytes().decode('latin1')
assert '"mt_switchbot", do_port_switchbot' in (SRC/'cmd.cpp').read_bytes().decode('latin1')
code=r'''
#include <cassert>
#include <cstdarg>
#include <cstdio>
#include <cstring>
#include <deque>
#include <map>
#include <memory>
#include <string>
#include <vector>
using DWORD=unsigned;using BYTE=unsigned char;
enum {MAX_APPLY_NUM=100,ITEM_APPLY_MAX_NUM=3,ATTRIBUTE_SET_MAX_NUM=11,INVENTORY_MAX_NUM=225,INVENTORY=1,EQUIPMENT=2};
enum {ITEM_USE=3,ITEM_COSTUME=28,USE_CHANGE_ATTRIBUTE=10,USE_ADD_ATTRIBUTE=11,APPLY_MAX_HP=1,APPLY_STR=3,APPLY_CRITICAL=15,
APPLY_ATTBONUS_MONSTER=63,APPLY_NORMAL_HIT_DAMAGE_BONUS=72,APPLY_SKILL_DAMAGE_BONUS=71};
enum {CHAT_TYPE_INFO=1,CHAT_TYPE_COMMAND=5};
struct TItemAttrTable{long lValues[5];BYTE bMaxLevelBySet[ATTRIBUTE_SET_MAX_NUM];};
std::map<DWORD,TItemAttrTable> g_map_itemAttr;
struct TItemApply{BYTE bType;long lValue;};
struct TItemTable{TItemApply aApplies[ITEM_APPLY_MAX_NUM];short sAddonType=0;};
struct TPlayerItemAttribute{BYTE bType=0;short sValue=0;};
struct TItemPos{BYTE window_type;unsigned cell;TItemPos(BYTE w,unsigned c):window_type(w),cell(c){}};
struct VID{DWORD id=0;bool operator==(const VID& o)const{return id==o.id;}};
struct event_info_data{virtual ~event_info_data(){}};
struct EVENT{event_info_data* info;long (*func)(EVENT*,long);bool cancelled=false;};
using LPEVENT=EVENT*;
std::vector<std::unique_ptr<EVENT>> events;
template<class T> T* AllocEventInfo(){return new T;}
LPEVENT event_create(long (*f)(LPEVENT,long),event_info_data* info,long){events.emplace_back(new EVENT{info,f});return events.back().get();}
void event_cancel(LPEVENT* e){if(*e)(*e)->cancelled=true;*e=nullptr;}
#define EVENTFUNC(name) long (name) (LPEVENT event, long processing_time)
#define EVENTINFO(name) struct name : public event_info_data
#define PASSES_PER_SEC(s) ((s)*4)
static DWORD clockms=1000;DWORD get_dword_time(){return clockms;}
struct CHARACTER;
struct CItem {
DWORD id,vnum;BYTE type,subtype;int set=0;unsigned cell;BYTE window=INVENTORY;bool equipped=false,exchanging=false;int count=1;
CHARACTER* owner=nullptr;TItemTable proto{};TPlayerItemAttribute attrs[7];
DWORD GetID(){return id;}DWORD GetVnum(){return vnum;}BYTE GetType(){return type;}BYTE GetSubType(){return subtype;}
int GetAttributeSetIndex(){return set;}const TItemTable* GetProto(){return &proto;}
const TPlayerItemAttribute& GetAttribute(int i){return attrs[i];}
int GetAttributeCount(){int n=0;for(int i=0;i<5;++i)n+=attrs[i].bType!=0;return n;}
CHARACTER* GetOwner(){return owner;}BYTE GetWindow(){return window;}unsigned GetCell(){return cell;}
bool IsEquipped(){return equipped;}bool IsExchanging(){return exchanging;}
};
using LPITEM=CItem*;
struct ITEM_MANAGER{
static const int MAX_NORM_ATTR_NUM=5;std::vector<CItem*> items;
static ITEM_MANAGER& instance(){static ITEM_MANAGER m;return m;}
LPITEM Find(DWORD id){for(auto* i:items)if(i->id==id)return i;return nullptr;}
};
struct CHARACTER {
DWORD m_portSwitchbotLastCommand=0;bool m_portQuietInfo=false;std::string m_portLastInfo;
DWORD pid=7;VID vid;bool desc=true,busy=false,dead=false,reject=false;int uses=0;
std::vector<std::string> messages,info;std::vector<CItem*> inventory;
std::deque<std::vector<std::pair<BYTE,short>>> rolls;
bool IsPC(){return true;}void* GetDesc(){return desc?this:nullptr;}DWORD GetPlayerID(){return pid;}const VID& GetVID(){return vid;}
bool IsDead(){return dead;}bool IsWarping(){return false;}bool CanHandleItem(){return !busy;}
void* GetExchange(){return nullptr;}void* GetMyShop(){return nullptr;}void* GetShopOwner(){return nullptr;}
bool IsOpenSafebox(){return false;}bool IsCubeOpen(){return false;}
LPITEM GetItem(TItemPos p){for(auto* i:inventory)if(i->window==p.window_type&&i->cell==p.cell)return i;return nullptr;}
LPITEM FindSpecifyItem(DWORD v){for(auto* i:inventory)if(i->vnum==v&&i->count>0)return i;return nullptr;}
int CountSpecifyItem(DWORD v){int n=0;for(auto* i:inventory)if(i->vnum==v)n+=i->count;return n;}
void ChatPacket(BYTE type,const char* format,...) {
char out[513];va_list args;va_start(args,format);vsnprintf(out,sizeof(out),format,args);va_end(args);
if(m_portQuietInfo && type==CHAT_TYPE_INFO){m_portLastInfo=out;return;}
(type==CHAT_TYPE_INFO?info:messages).emplace_back(out);
}
// Original contract: INFO line on every call, one scroll consumed per successful change.
bool UseItem(TItemPos scroll,TItemPos target) {
++uses;LPITEM s=GetItem(scroll),t=GetItem(target);assert(s && t && s->subtype==USE_CHANGE_ATTRIBUTE);
if(reject){ChatPacket(CHAT_TYPE_INFO,"cannot change");return false;}
auto roll=rolls.front();rolls.pop_front();
for(int i=0;i<5;++i)t->attrs[i]=TPlayerItemAttribute{};
for(size_t i=0;i<roll.size();++i){t->attrs[i].bType=roll[i].first;t->attrs[i].sValue=roll[i].second;}
--s->count;ChatPacket(CHAT_TYPE_INFO,"changed");return true;
}
};
using LPCHARACTER=CHARACTER*;
struct CHARACTER_MANAGER{
std::vector<CHARACTER*> chars;static CHARACTER_MANAGER& instance(){static CHARACTER_MANAGER m;return m;}
LPCHARACTER Find(const VID& v){for(auto* c:chars)if(c->vid==v)return c;return nullptr;}
};
#define ACMD(name) void name(LPCHARACTER ch,const char* argument)
#include "port_switchbot.h"
static CHARACTER ch;
static void cmd(const char* text){clockms+=300;ch.messages.clear();do_port_switchbot(&ch,text);}
static long tick(){for(auto& e:events)if(!e->cancelled&&e->func){long r=e->func(e.get(),0);if(!r)e->func=nullptr;return r;}return -1;}
static const std::string& last(){return ch.messages.back();}
int main(){
g_map_itemAttr[APPLY_MAX_HP]={{500,1000,1500,2000,2500},{5,5}};
g_map_itemAttr[APPLY_STR]={{2,4,6,8,12},{5,0}}; // body only (set 0)
g_map_itemAttr[APPLY_CRITICAL]={{1,2,3,5,10},{0,5}}; // not on set 0
g_map_itemAttr[APPLY_ATTBONUS_MONSTER]={{2,4,6,8,10},{3,5}}; // level-capped at 3 on set 0
ch.vid.id=99;CHARACTER_MANAGER::instance().chars.push_back(&ch);
CItem armor{1001,11209,2,0,0,10};armor.owner=&ch;armor.proto.aApplies[0]={APPLY_MAX_HP,100};armor.attrs[0]={APPLY_STR,2};armor.attrs[1]={APPLY_CRITICAL,1};
CItem scroll{2001,71084,ITEM_USE,USE_CHANGE_ATTRIBUTE,-1,20};scroll.owner=&ch;scroll.count=3;
CItem adder{2002,71085,ITEM_USE,USE_ADD_ATTRIBUTE,-1,21};adder.owner=&ch;
CItem plain{1002,50001,ITEM_USE,0,-1,30};plain.owner=&ch;
for(auto* i:{&armor,&scroll,&adder,&plain}){ch.inventory.push_back(i);ITEM_MANAGER::instance().items.push_back(i);}
// Allowed list: proto applies excluded, set filter, level cap picks lValues[level-1].
cmd("1 attrs 10");
assert(ch.messages.size()==4 && ch.messages[0]=="MTSB1 attrs 10 11209 2");
assert(ch.messages[1]=="MTSB1 attr 0 3 12" && ch.messages[2]=="MTSB1 attr 1 63 6" && last()=="MTSB1 attrs_end 10 2");
armor.proto.sAddonType=1;cmd("1 attrs 10");assert(ch.messages[3]=="MTSB1 attr 2 71 30" && ch.messages[4]=="MTSB1 attr 3 72 65");armor.proto.sAddonType=0;
cmd("1 attrs 30");assert(last()=="MTSB1 error attrs no_attr");
cmd("1 attrs 99");assert(last()=="MTSB1 error attrs item");
do_port_switchbot(&ch,"1 attrs 10");assert(last()=="MTSB1 error attrs rate");
// Validation.
for(auto bad:{"1 start 10 71084 0 1 3 1","1 start 10 71084 1001 1 3 1","1 start 10 71084 5 1 3","1 start 10 71084 5 1 3 0",
"1 start 10 71084 5 6 3 1 3 1 3 1 3 1 3 1 3 1","1 start 10 71084 5 1 3 1 1","1 start 10 71084 5 1 3 -1","1 start 10 71084 5 0"})
{cmd(bad);assert(last()=="MTSB1 error start invalid");}
cmd("1 start 10 71084 5 1 1 100");assert(last()=="MTSB1 error start target"); // base proto apply
cmd("1 start 10 71084 5 1 3 13");assert(last()=="MTSB1 error start target"); // above max
cmd("1 start 10 71084 5 2 3 1 3 2");assert(last()=="MTSB1 error start target"); // duplicate
cmd("1 start 10 71085 5 1 3 4");assert(last()=="MTSB1 error start scroll");
cmd("1 start 10 50001 5 1 3 4");assert(last()=="MTSB1 error start scroll");
cmd("1 start 30 71084 5 1 3 4");assert(last()=="MTSB1 error start no_attr");
armor.equipped=true;cmd("1 start 10 71084 5 1 3 4");assert(last()=="MTSB1 error start equipped");armor.equipped=false;
cmd("1 start 10 71084 5 1 3 2");assert(last()=="MTSB1 state 0 10 11209 0 5 71084 3 matched" && events.empty()); // already satisfied
assert(ch.uses==0);
// Run: two alternatives, first roll misses, second satisfies alternative 2; INFO spam suppressed.
ch.rolls={{{APPLY_STR,4},{APPLY_CRITICAL,1}},{{APPLY_ATTBONUS_MONSTER,6},{APPLY_STR,2}}};
cmd("1 start 10 71084 10 1 3 8 2 63 6 3 2");assert(last()=="MTSB1 state 1 10 11209 0 10 71084 3 running");
cmd("1 start 10 71084 10 1 3 8");assert(last()=="MTSB1 error start running");
ch.messages.clear();assert(tick()==1);assert(last()=="MTSB1 state 1 10 11209 1 10 71084 2 running");
assert(tick()==0 && last()=="MTSB1 state 0 10 11209 2 10 71084 1 matched");
assert(ch.info.empty() && !ch.m_portQuietInfo && ch.uses==2 && g_portSwitchbots.empty());
// Limit, then scroll exhaustion.
scroll.count=5;ch.rolls={{{APPLY_STR,2}},{{APPLY_STR,2}},{{APPLY_STR,2}}};
cmd("1 start 10 71084 2 1 3 12");ch.messages.clear();tick();
assert(tick()==0 && last()=="MTSB1 state 0 10 11209 2 2 71084 3 limit");
scroll.count=1;cmd("1 start 10 71084 5 1 3 12");ch.messages.clear();tick();
assert(tick()==0 && last()=="MTSB1 state 0 10 11209 1 5 71084 0 no_scroll");
// Rejected roll: no consumption, the original INFO is surfaced once.
scroll.count=2;ch.reject=true;cmd("1 start 10 71084 5 1 3 12");tick();
assert(last()=="MTSB1 state 0 10 11209 0 5 71084 2 rejected" && ch.info.size()==1 && ch.info[0]=="cannot change");
ch.reject=false;ch.info.clear();
// Item moved to equipment, busy character, manual stop, logout/warp (VID change) erases silently.
ch.rolls={{{APPLY_STR,2}}};cmd("1 start 10 71084 5 1 3 12");armor.window=EQUIPMENT;tick();
assert(last()=="MTSB1 state 0 0 0 0 5 71084 2 item_gone");armor.window=INVENTORY;
cmd("1 start 10 71084 5 1 3 12");ch.busy=true;tick();assert(last()=="MTSB1 state 0 10 11209 0 5 71084 2 busy");ch.busy=false;
cmd("1 start 10 71084 5 1 3 12");cmd("1 stop");assert(last()=="MTSB1 state 0 10 11209 0 5 71084 2 stopped" && tick()==-1);
cmd("1 stop");assert(last()=="MTSB1 state 0 0 0 0 0 0 0 idle");
cmd("1 start 10 71084 5 1 3 12");cmd("1 status");assert(last()=="MTSB1 state 1 10 11209 0 5 71084 2 running");
ch.vid.id=100;ch.messages.clear();assert(tick()==0 && ch.messages.empty() && g_portSwitchbots.empty());
assert(ch.uses==6);
// Malformed or foreign input is ignored or rejected without side effects.
cmd("2 status");assert(ch.messages.empty());
cmd("1 explode");assert(last()=="MTSB1 error explode invalid");
cmd("1 start 99999999999 71084 5 1 3 12");assert(ch.messages.empty()); // overlong token
puts("PASS: allowed targets, validation, alternatives, original UseItem path, quiet INFO, stop reasons, VID drop");
}
'''
with tempfile.TemporaryDirectory(prefix='mt-switchbot-') as folder:
path=Path(folder);(path/'test.cpp').write_text(code)
subprocess.run(['c++','-std=c++17','-Wall','-I'+str(SRC),str(path/'test.cpp'),'-o',str(path/'test')],check=True)
subprocess.run([str(path/'test')],check=True)